Repository navigation
[sqlite3] remove pre SQLite 3.7.7 support code #87480
Description
| BPO | 43314 |
|---|---|
| Nosy | @berkerpeksag, @serhiy-storchaka, @erlend-aasland |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2021-02-26.00:48:55.382>
created_at = <Date 2021-02-24.10:48:54.130>
labels = ['type-feature', 'library', '3.10']
title = '[sqlite3] remove pre SQLite 3.7.7 support code'
updated_at = <Date 2021-02-26.00:48:55.381>
user = 'https://github.com/erlend-aasland'bugs.python.org fields:
activity = <Date 2021-02-26.00:48:55.381>
actor = 'berker.peksag'
assignee = 'none'
closed = True
closed_date = <Date 2021-02-26.00:48:55.382>
closer = 'berker.peksag'
components = ['Library (Lib)']
creation = <Date 2021-02-24.10:48:54.130>
creator = 'erlendaasland'
dependencies = []
files = []
hgrepos = []
issue_num = 43314
keywords = ['patch']
message_count = 2.0
messages = ['387616', '387697']
nosy_count = 3.0
nosy_names = ['berker.peksag', 'serhiy.storchaka', 'erlendaasland']
pr_nums = ['24637']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue43314'
versions = ['Python 3.10']
Activity
erlend-aasland commentedon Feb 24, 2021
I missed the SQLITE_OPEN_URI #ifdef in #68294. The "open URI" interface was added in 3.7.7. The dead code can safely be removed.
$ grep -r SQLITE_OPEN_URI sqlite-3.7.6/ $ grep -r SQLITE_OPEN_URI sqlite-3.7.7/ [...] sqlite-3.7.7/sqlite3.h:#define SQLITE_OPEN_URI 0x00000040 /* Ok for sqlite3_open_v2() */berkerpeksag commentedon Feb 26, 2021
New changeset 3150754 by Erlend Egeberg Aasland in branch 'master':
bpo-43314: Remove SQLITE_OPEN_URI ifdef (GH-24637)
3150754