Skip to content

Arguments missing from documentation for HTTPErrorProcessor.http(s)_response() #78599

Closed

Description

@srittau
mannequin
BPO 34418
Nosy @srittau, @berkerpeksag, @miss-islington
PRs
  • bpo-34418: Fix HTTPErrorProcessor documentation #8793
  • [3.7] bpo-34418: Fix HTTPErrorProcessor documentation (GH-8793) #8794
  • [3.6] bpo-34418: Fix HTTPErrorProcessor documentation (GH-8793) #8795
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2018-08-17.10:37:24.280>
    created_at = <Date 2018-08-17.07:45:47.213>
    labels = ['3.8', 'type-bug', '3.7', 'docs']
    title = 'Arguments missing from documentation for HTTPErrorProcessor.http(s)_response()'
    updated_at = <Date 2018-08-17.10:37:24.276>
    user = 'https://github.com/srittau'

    bugs.python.org fields:

    activity = <Date 2018-08-17.10:37:24.276>
    actor = 'berker.peksag'
    assignee = 'docs@python'
    closed = True
    closed_date = <Date 2018-08-17.10:37:24.280>
    closer = 'berker.peksag'
    components = ['Documentation']
    creation = <Date 2018-08-17.07:45:47.213>
    creator = 'srittau'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 34418
    keywords = ['patch']
    message_count = 5.0
    messages = ['323638', '323641', '323643', '323645', '323646']
    nosy_count = 4.0
    nosy_names = ['srittau', 'docs@python', 'berker.peksag', 'miss-islington']
    pr_nums = ['8793', '8794', '8795']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue34418'
    versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

    Activity

    1. srittau commented on Aug 17, 2018

      srittaumannequin
      MannequinAuthor

      The documentation at https://docs.python.org/3/library/urllib.request.html#urllib.request.HTTPErrorProcessor does not list the two arguments "request" and "response" that HTTPErrorProcessor.http_response() and https_response() actually require. (I checked the implementation in Python 3.5 and 3.7.)

    2. berkerpeksag commented on Aug 17, 2018

      @berkerpeksag
      Member

      New changeset c53aaec by Berker Peksag (Sebastian Rittau) in branch 'master':
      bpo-34418: Fix HTTPErrorProcessor documentation (GH-8793)
      c53aaec

    3. miss-islington commented on Aug 17, 2018

      @miss-islington
      Contributor

      New changeset 05d89ef by Miss Islington (bot) in branch '3.7':
      bpo-34418: Fix HTTPErrorProcessor documentation (GH-8793)
      05d89ef

    4. berkerpeksag commented on Aug 17, 2018

      @berkerpeksag
      Member

      New changeset 02c4d4b by Berker Peksag (Miss Islington (bot)) in branch '3.6':
      bpo-34418: Fix HTTPErrorProcessor documentation (GH-8793)
      02c4d4b

    5. berkerpeksag commented on Aug 17, 2018

      @berkerpeksag
      Member

      Thanks for the report and for the patch! 3.5 is in security-fix-only mode, so it doesn't get documentation fixes anymore.

    6. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      3.7 (EOL)end of life3.8 (EOL)end of lifedocsDocumentation in the Doc dirtype-bugAn unexpected behavior, bug, or error

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions