Repository navigation
Document more BaseHTTPRequestHandler attributes #67598
Description
| BPO | 23410 |
|---|---|
| Nosy | @berkerpeksag, @vadmium, @demianbrecht |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2015-02-18.02:13:37.942>
created_at = <Date 2015-02-08.10:21:17.617>
labels = ['type-feature', 'library', 'docs']
title = 'Document more BaseHTTPRequestHandler attributes'
updated_at = <Date 2015-02-18.02:13:37.897>
user = 'https://github.com/vadmium'bugs.python.org fields:
activity = <Date 2015-02-18.02:13:37.897>
actor = 'python-dev'
assignee = 'docs@python'
closed = True
closed_date = <Date 2015-02-18.02:13:37.942>
closer = 'python-dev'
components = ['Documentation', 'Library (Lib)']
creation = <Date 2015-02-08.10:21:17.617>
creator = 'martin.panter'
dependencies = []
files = ['38042', '38141', '38157']
hgrepos = []
issue_num = 23410
keywords = ['patch']
message_count = 7.0
messages = ['235554', '235941', '236018', '236124', '236126', '236127', '236162']
nosy_count = 5.0
nosy_names = ['docs@python', 'python-dev', 'berker.peksag', 'martin.panter', 'demian.brecht']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue23410'
versions = []
Activity
vadmium commentedon Feb 8, 2015
[Padding to avoid Error: 'utf8' codec can't decode bytes in position 189-190: invalid continuation byte]
This is a patch to document two attributes of http.server.BaseHTTPRequestHandler: “close_connection” and “requestline”. Normally these are set by the handle_one_request() method, but when overriding that method, you need to know to set these attributes.
demianbrecht commentedon Feb 14, 2015
Minor comment in Rietveld, otherwise LGTM.
vadmium commentedon Feb 15, 2015
Posting another patch which hopefully explains the “requestline” attribute a bit better. Let me know if you have any ideas for better wording.
vadmium commentedon Feb 17, 2015
Posting patch v3. It is based on Demian’s suggested wording for the requestline attribute, but adjusted to match the other entries, and to mention the empty string.
demianbrecht commentedon Feb 17, 2015
LGTM
demianbrecht commentedon Feb 17, 2015
Added Library component as there are a few newly added tests as well though and cosmetic changes were made to server.py.
python-dev commentedon Feb 18, 2015
New changeset f9ff2a5bbbe2 by Benjamin Peterson in branch '3.4':
document the requestline and close_connection attributes, use real booleans, and add tests (closes bpo-23410)
https://hg.python.org/cpython/rev/f9ff2a5bbbe2
New changeset 6e3e252cf047 by Benjamin Peterson in branch 'default':
merge 3.4 (bpo-23410)
https://hg.python.org/cpython/rev/6e3e252cf047