Repository navigation
Hide symbols in _decimal.so #60949
Description
| BPO | 16745 |
|---|---|
| Nosy | @malemburg, @loewis, @doko42, @pitrou, @tiran, @skrah, @davidmalcolm, @meadori |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/skrah'
closed_at = <Date 2012-12-23.11:09:58.059>
created_at = <Date 2012-12-21.17:15:33.463>
labels = ['extension-modules', 'type-feature']
title = 'Hide symbols in _decimal.so'
updated_at = <Date 2012-12-23.11:09:58.058>
user = 'https://github.com/skrah'bugs.python.org fields:
activity = <Date 2012-12-23.11:09:58.058>
actor = 'skrah'
assignee = 'skrah'
closed = True
closed_date = <Date 2012-12-23.11:09:58.059>
closer = 'skrah'
components = ['Extension Modules']
creation = <Date 2012-12-21.17:15:33.463>
creator = 'skrah'
dependencies = []
files = ['28385']
hgrepos = []
issue_num = 16745
keywords = ['patch']
message_count = 8.0
messages = ['177883', '177886', '177890', '177894', '177896', '177904', '177941', '177959']
nosy_count = 9.0
nosy_names = ['lemburg', 'loewis', 'doko', 'pitrou', 'christian.heimes', 'skrah', 'dmalcolm', 'meador.inge', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue16745'
versions = ['Python 3.3', 'Python 3.4']
Activity
skrah commentedon Dec 21, 2012
This issue is for the _decimal specific parts from bpo-4555. The patch
depends on _Pragma (C99) and gcc >= 4.0 for the contents of the pragma.
I think it will work for clang, too.
Should the libmpdec API symbols (i.e. the ones starting with mpd_*)
be hidden for _decimal.c, too?
skrah commentedon Dec 21, 2012
Adding everyone from issue bpo-4555, in case you can think of a different
(portable) solution for hiding symbols (with minimal effort).
meadori commentedon Dec 21, 2012
Personally I prefer using attributes instead of pragmas. The GCC manual recommends such as well. There are also other sources in Modules/* that use '__attribute__ ((visibility ("hidden")))'. Namely ctypes and zlib.
I can understand that it is more work, but I find something like the following more readable (I am not actually suggesting names here, just an example):
...
skrah commentedon Dec 21, 2012
Meador Inge <report@bugs.python.org> wrote:
I followed www.akkadia.org/drepper/dsohowto.pdf . Drepper seems to be fine
with the use of pragmas in internal headers.
They do, but for a tiny amount of functions. mpdecimal.h, which is internal
as far as _decimal.so is concerned, also needs to be changed. There you have
something like 200 lines of
which increases the size of the diff between the standalone libmpdec and the
one shipped with Python.
meadori commentedon Dec 21, 2012
Ah, I missed how big of a line range these pragmas are covering when I scanned the patch before. In that case, I agree with the current patch.
python-dev commentedon Dec 21, 2012
New changeset 24f6c6f3b7bf by Stefan Krah in branch '3.3':
Issue bpo-16745: Hide a couple of symbols by making them local.
http://hg.python.org/cpython/rev/24f6c6f3b7bf
python-dev commentedon Dec 22, 2012
New changeset 51b0a150f8aa by Stefan Krah in branch '3.3':
Issue bpo-16745: Hide symbols in _decimal.so.
http://hg.python.org/cpython/rev/51b0a150f8aa
python-dev commentedon Dec 22, 2012
New changeset ccc372b37fbb by Stefan Krah in branch '3.3':
Issue bpo-16745: The gcc visibility pragma is buggy on OpenIndiana and NetBSD.
http://hg.python.org/cpython/rev/ccc372b37fbb