Skip to content

fix: added missing assert parameters in documentation - #1023

Merged
shvaikalesh merged 1 commit into
chaijs:masterfrom
Hpauric:add-missing-assert-parameters
Aug 9, 2017
Merged

shvaikalesh merged 1 commit into
chaijs:masterfrom
Hpauric:add-missing-assert-parameters

Conversation

@Hpauric

@Hpauric Hpauric commented Aug 9, 2017

Copy link
Copy Markdown
Contributor

Fix for issue #1017

Optional message parameter added to documentation for:

  • .ifError
  • .isExtensible
  • .isNotExtensible
  • .isFrozen
  • .isNotFrozen
  • .isEmpty
  • .isNotEmpty

@Hpauric
Hpauric requested a review from a team as a code owner August 9, 2017 10:05

@keithamus keithamus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. @chaijs/chai anyone else want to approve + merge this?

@keithamus

Copy link
Copy Markdown
Member

Just noticed this PR edited chai.js - so we'll need to rework this to the right places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants