Repository navigation
Removed OSError in favour of DecompressionBombError for BMP - #4966
Merged
Merged
Conversation
radarhere
changed the title
hugovk
approved these changes
Oct 12, 2020
hugovk
left a comment
hugovk
left a comment
Member
There was a problem hiding this comment.
Thanks! Let's also put this in the release notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4939
At the moment, a very large BMP file does not raise a DecompressionBombError, but instead an OSError. This PR changes it so that the more standard DecompressionBombError is raised.