Skip to content

MAINT: add missing dunder method to nditer type hints - #19652

Merged
charris merged 2 commits into
numpy:maintenance/1.21.xfrom
BvB93:dunders
Aug 12, 2021
Merged

charris merged 2 commits into
numpy:maintenance/1.21.xfrom
BvB93:dunders

Conversation

@BvB93

@BvB93 BvB93 commented Aug 12, 2021

Copy link
Copy Markdown
Member

Backport of #19554

Closes #19551

The presence of __getattr__ is not sufficient to enable all protocols so explicitely add the dunder methods supported by nditer
@BvB93 BvB93 added 08 - Backport Used to tag backport PRs 41 - Static typing labels Aug 12, 2021
@BvB93 BvB93 added this to the 1.21.2 release milestone Aug 12, 2021
@charris
charris merged commit 27d71dc into numpy:maintenance/1.21.x Aug 12, 2021
@charris

charris commented Aug 12, 2021

Copy link
Copy Markdown
Member

Thanks Bas.

@BvB93
BvB93 deleted the dunders branch August 16, 2021 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants