Repository navigation
DEP: remove PolyBase from np.polynomial.polyutils - #18963
Conversation
|
Can you also remove the exceptions from the stub file? numpy/numpy/polynomial/polyutils.pyi Lines 6 to 10 in d3b03c8 |
2b38f7c to
360a959
Compare
|
All done @BvB93 ... thanks for the heads up. Do let me know if I missed anything. |
|
This could use a release note. See |
Nop, no further annotation-related comments from me. |
Addresses issue numpy#15658 by removing PolyBase class. Happy to submit alternative PR using getattr approach instead if desired.
Additionally removes associated PolyError classes. These appear to me to be unused outside this file.
Update stubs
Note removal in release notes
a70d828 to
7ef9da0
Compare
|
@charris PR updated. Happy to squash before merge if preferred. |
rossbar
left a comment
rossbar
left a comment
There was a problem hiding this comment.
I took the liberty of adding a few minor touchups to the release note (basically just formatting + mentioning that the Exceptions are also removed).
LGTM - I'm in favor of removing the objects outright. Thanks @hollycorbett !
|
@rossbar feedback much appreciated - agree your edit is much better. Thanks! :)
|
|
Thanks @hollycorbett . |
4 participants
DEP: Remove PolyBase from np.polynomial.polyutils
Addresses issue #15658 by removing PolyBase and associated error classes with only usages here. Happy to submit alternative PR using getattr approach instead if desired.