Repository navigation
add basic support for hu and lt localizations - #864
Conversation
add basic support for hu and lt localizations
kossnocorp
left a comment
kossnocorp
left a comment
There was a problem hiding this comment.
Please fix the comments and also add an entry to the change log: https://github.com/date-fns/date-fns/blob/master/CHANGELOG.md
|
@leshakoss, please take a glance. |
…u-lt-latest-version update version of lt and hu localizations
kossnocorp
left a comment
kossnocorp
left a comment
There was a problem hiding this comment.
That is looking good, thank you guys for your work!
| @@ -0,0 +1,135 @@ | |||
| var formatDistanceLocale = { | |||
| lessThanXSeconds: { | |||
| one: translate, | |||
There was a problem hiding this comment.
I have a feeling that this could be improved somehow. formatDistance file doesn't has to have this exact structure
There was a problem hiding this comment.
Oops, this is already merged 😀
There was a problem hiding this comment.
have a feeling that this could be improved somehow.
formatDistancefile doesn't has to have this exact structure
@leshakoss could you please elaborate what do you mean by that? Guys could improve in following PRs.
There was a problem hiding this comment.
In this case formatDistanceLocale object is not really needed because the logic is handled by translate function below
|
I'm going to release a new version soon. Stay tuned! |
|
I've just published a new version with this locale Thank you again for your work! |
4 participants
No description provided.