Repository navigation
Added locale en-GB - #563
Conversation
leshakoss
left a comment
leshakoss
left a comment
There was a problem hiding this comment.
Good job! 👍 Please fix the code style issue and we're good to go
| * @category Locales | ||
| * @summary English locale (United Kingdom). | ||
| * @language English | ||
| * @iso-639-2 eng |
There was a problem hiding this comment.
Please add @author tag, like this:
* @author Alex [@glintik]{@link https://github.com/glintik}
leshakoss
left a comment
leshakoss
left a comment
There was a problem hiding this comment.
Oops, missed a comment in the last review. This code style issue:
| LT: 'HH:mm', | ||
| LTS: 'HH:mm:ss', | ||
| L: 'DD/MM/YYYY', | ||
| LL : 'D MMMM YYYY', |
There was a problem hiding this comment.
Please remove extra space after key here and in two following lines. https://travis-ci.org/date-fns/date-fns/jobs/276343759#L490-L492
|
Sorry, forgot to run eslint. Fixed. |
|
@glintik while we're waiting for @kossnocorp to release this as a new version, could you please add |
|
It's released as Thank you! |
4 participants
Hi,
Locale en-GB is added and tested.