Skip to content

Commit 226e6dc

Browse files
raphaelzulligerisaacs
raphaelzulliger
authored and
isaacs
committed
Fixed variable names and comments
PR-URL: #315 Credit: @raphaelzulliger Close: #315 Reviewed-by: @isaacs
1 parent ce978f9 commit 226e6dc

7 files changed

Lines changed: 36 additions & 36 deletions

File tree

‎test/fixtures/version-gt-range.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// [range, version, loose]
1+
// [range, version, options]
22
// Version should be greater than range
33
module.exports = [
44
['~1.2.2', '1.3.0'],

‎test/fixtures/version-lt-range.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// [range, version, loose]
1+
// [range, version, options]
22
// Version should be less than range
33
module.exports = [
44
['~1.2.2', '1.2.1'],

‎test/fixtures/version-not-gt-range.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// [range, version, loose]
1+
// [range, version, options]
22
// Version should NOT be greater than range
33
module.exports = [
44
['~0.6.1-1', '0.6.1-1'],

‎test/fixtures/version-not-lt-range.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// [range, version, loose]
1+
// [range, version, options]
22
// Version should NOT be less than range
33
module.exports = [
44
['~ 1.0', '1.1.0'],

‎test/ranges/gtr.js‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,27 +4,27 @@ const versionGtr = require('../fixtures/version-gt-range')
44
const versionNotGtr = require('../fixtures/version-not-gt-range')
55

66
test('gtr tests', (t) => {
7-
// [range, version, loose]
7+
// [range, version, options]
88
// Version should be greater than range
99
versionGtr.forEach((tuple) => {
1010
const range = tuple[0]
1111
const version = tuple[1]
12-
const loose = tuple[2] || false
13-
const msg = `gtr(${version}, ${range}, ${loose})`
14-
t.ok(gtr(version, range, loose), msg)
12+
const options = tuple[2] || false
13+
const msg = `gtr(${version}, ${range}, ${options})`
14+
t.ok(gtr(version, range, options), msg)
1515
})
1616
t.end()
1717
})
1818

1919
test('negative gtr tests', (t) => {
20-
// [range, version, loose]
20+
// [range, version, options]
2121
// Version should NOT be greater than range
2222
versionNotGtr.forEach((tuple) => {
2323
const range = tuple[0]
2424
const version = tuple[1]
25-
const loose = tuple[2] || false
26-
const msg = `!gtr(${version}, ${range}, ${loose})`
27-
t.notOk(gtr(version, range, loose), msg)
25+
const options = tuple[2] || false
26+
const msg = `!gtr(${version}, ${range}, ${options})`
27+
t.notOk(gtr(version, range, options), msg)
2828
})
2929
t.end()
3030
})

‎test/ranges/ltr.js‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,21 @@ const versionLtr = require('../fixtures/version-lt-range')
44
const versionNotLtr = require('../fixtures/version-not-lt-range')
55

66
test('ltr tests', (t) => {
7-
// [range, version, loose]
7+
// [range, version, options]
88
// Version should be less than range
9-
versionLtr.forEach(([range, version, loose = false]) => {
10-
const msg = `ltr(${version}, ${range}, ${loose})`
11-
t.ok(ltr(version, range, loose), msg)
9+
versionLtr.forEach(([range, version, options = false]) => {
10+
const msg = `ltr(${version}, ${range}, ${options})`
11+
t.ok(ltr(version, range, options), msg)
1212
})
1313
t.end()
1414
})
1515

1616
test('negative ltr tests', (t) => {
17-
// [range, version, loose]
17+
// [range, version, options]
1818
// Version should NOT be less than range
19-
versionNotLtr.forEach(([range, version, loose = false]) => {
20-
const msg = `!ltr(${version}, ${range}, ${loose})`
21-
t.notOk(ltr(version, range, loose), msg)
19+
versionNotLtr.forEach(([range, version, options = false]) => {
20+
const msg = `!ltr(${version}, ${range}, ${options})`
21+
t.notOk(ltr(version, range, options), msg)
2222
})
2323
t.end()
2424
})

‎test/ranges/outside.js‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -6,41 +6,41 @@ const versionLtr = require('../fixtures/version-lt-range')
66
const versionNotLtr = require('../fixtures/version-not-lt-range')
77

88
test('gtr tests', (t) => {
9-
// [range, version, loose]
9+
// [range, version, options]
1010
// Version should be greater than range
11-
versionGtr.forEach(([range, version, loose = false]) => {
12-
const msg = `outside(${version}, ${range}, > ${loose})`
13-
t.ok(outside(version, range, '>', loose), msg)
11+
versionGtr.forEach(([range, version, options = false]) => {
12+
const msg = `outside(${version}, ${range}, > ${options})`
13+
t.ok(outside(version, range, '>', options), msg)
1414
})
1515
t.end()
1616
})
1717

1818
test('ltr tests', (t) => {
19-
// [range, version, loose]
19+
// [range, version, options]
2020
// Version should be less than range
21-
versionLtr.forEach(([range, version, loose = false]) => {
22-
const msg = `outside(${version}, ${range}, <, ${loose})`
23-
t.ok(outside(version, range, '<', loose), msg)
21+
versionLtr.forEach(([range, version, options = false]) => {
22+
const msg = `outside(${version}, ${range}, <, ${options})`
23+
t.ok(outside(version, range, '<', options), msg)
2424
})
2525
t.end()
2626
})
2727

2828
test('negative gtr tests', (t) => {
29-
// [range, version, loose]
29+
// [range, version, options]
3030
// Version should NOT be greater than range
31-
versionNotGtr.forEach(([range, version, loose = false]) => {
32-
const msg = `!outside(${version}, ${range}, > ${loose})`
33-
t.notOk(outside(version, range, '>', loose), msg)
31+
versionNotGtr.forEach(([range, version, options = false]) => {
32+
const msg = `!outside(${version}, ${range}, > ${options})`
33+
t.notOk(outside(version, range, '>', options), msg)
3434
})
3535
t.end()
3636
})
3737

3838
test('negative ltr tests', (t) => {
39-
// [range, version, loose]
39+
// [range, version, options]
4040
// Version should NOT be less than range
41-
versionNotLtr.forEach(([range, version, loose = false]) => {
42-
const msg = `!outside(${version}, ${range}, < ${loose})`
43-
t.notOk(outside(version, range, '<', loose), msg)
41+
versionNotLtr.forEach(([range, version, options = false]) => {
42+
const msg = `!outside(${version}, ${range}, < ${options})`
43+
t.notOk(outside(version, range, '<', options), msg)
4444
})
4545
t.end()
4646
})

0 commit comments

Comments
 (0)