Use ipaddress module for no_proxy parsing - #1033
Merged
Merged
Conversation
Collaborator
|
I cannot add my changes to this to fix failing CI @jplitza because I don't have proper permissions. But you need to apply black formatting and fix the AssertionError in test_connect to make CI pass. If this is not changed in 2 weeks, I will make a duplicate PR with a similar edit, with the CI fixes. |
This enables support for IPv6 CIDRs in the no_proxy option
Contributor
Author
|
That should do it. Those black findings were both outside what I changed, so I hoped rebasing would fix it, but it didn't. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1033 +/- ##
==========================================
+ Coverage 82.59% 84.97% +2.37%
==========================================
Files 13 14 +1
Lines 1396 1484 +88
Branches 264 279 +15
==========================================
+ Hits 1153 1261 +108
+ Misses 163 121 -42
- Partials 80 102 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Thanks for the PR, and the quick fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables support for IPv6 CIDRs in the no_proxy option