Skip to content

Use ipaddress module for no_proxy parsing - #1033

Merged
engn33r merged 2 commits into
websocket-client:masterfrom
jplitza:noproxy-ipv6
Oct 4, 2025
Merged

engn33r merged 2 commits into
websocket-client:masterfrom
jplitza:noproxy-ipv6

Conversation

@jplitza

@jplitza jplitza commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

This enables support for IPv6 CIDRs in the no_proxy option

@engn33r

engn33r commented Oct 4, 2025

Copy link
Copy Markdown
Collaborator

I cannot add my changes to this to fix failing CI @jplitza because I don't have proper permissions. But you need to apply black formatting and fix the AssertionError in test_connect to make CI pass.

If this is not changed in 2 weeks, I will make a duplicate PR with a similar edit, with the CI fixes.

This enables support for IPv6 CIDRs in the no_proxy option
@jplitza

jplitza commented Oct 4, 2025

Copy link
Copy Markdown
Contributor Author

That should do it. Those black findings were both outside what I changed, so I hoped rebasing would fix it, but it didn't.

@codecov

codecov Bot commented Oct 4, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.97%. Comparing base (981c00e) to head (cc5a372).
⚠️ Report is 31 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1033      +/-   ##
==========================================
+ Coverage   82.59%   84.97%   +2.37%     
==========================================
  Files          13       14       +1     
  Lines        1396     1484      +88     
  Branches      264      279      +15     
==========================================
+ Hits         1153     1261     +108     
+ Misses        163      121      -42     
- Partials       80      102      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@engn33r
engn33r merged commit 6861ee4 into websocket-client:master Oct 4, 2025
10 checks passed
@engn33r

engn33r commented Oct 4, 2025

Copy link
Copy Markdown
Collaborator

Thanks for the PR, and the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants