Activity

1. TheLarkInn commented on Apr 14, 2023

   

   TheLarkInn

   on Apr 14, 2023

   Last edited by TheLarkInn

   Member

   More actions

   @aboktor (also cc @alexander-akait @snitin315):

   If we create an output.scriptFetchPriority option, this would mean that every lazy loaded bundle would apply the same priority.

   Similar to how we provide the prefetch and preload options:

   import(
     /* webpackInclude: /\.json$/ */
     /* webpackExclude: /\.noimport\.json$/ */
     /* webpackChunkName: "my-chunk-name" */
     /* webpackMode: "lazy" */
     /* webpackPrefetch: true */
     /* webpackPreload: true */
     `./locale/${language}`
   );

   Would it be a better design to have customizable fetch priority per each lazy-loaded bundle?

   import(
     /* webpackFetchPriority: "high" */
     `./locale/${language}`
   );

   Alternatively we could have both options. If we go that route I would want to limit the users barrier to complexity with managing both of the options and how they override eachother. That would need to be fleshed out if so. A suggestion for this "dual design" would be:

   • output.scriptFetchPriority applies fetch priority to all lazy loaded bundles, it defaults to false
   • webpackFetchPriority magic comment overrides the global output.scriptFetchPriority if used also defaults to false
   • Since this is a web-only feature it would only be needed for web-based targets where jsonp script insertion is used.

   Thoughts?
2. TheLarkInn

   added

   enhancement

   X5: work required (PR / Help Wanted)

   X3: discussion required

   help wantedMaintainers welcome a community PR for thisMaintainers welcome a community PR for this

   on Apr 14, 2023
3. aboktor commented on Apr 14, 2023

   

   aboktor

   on Apr 14, 2023

   ContributorAuthor

   More actions

   My usecase requires applying it globally to every lazy loaded bundle.
   If we think users will want to customize this per import then I think what @TheLarkInn is proposing would work quite well.

   🚀React with 🚀1Reacted by Sean Larkin
4. TheLarkInn commented on Apr 14, 2023

   

   TheLarkInn

   on Apr 14, 2023

   Member

   More actions

   If you are onboard with this work as suggested, I think we are happy to take a PR for this. Can iterate on regular or draft PR. Either works!
5. alexander-akait commented on Apr 14, 2023

   

   alexander-akait

   on Apr 14, 2023

   Member

   More actions

   @aboktor Let's use fetchPriority, because we have built-in CSS support and it will be useful to implement for link too

   👍React with 👍1Reacted by Sean Larkin
6. alexander-akait commented on Apr 14, 2023

   

   alexander-akait

   on Apr 14, 2023

   Last edited by alexander-akait

   Member

   More actions

   @aboktor i.e. I think we don't need output.scriptFetchPriority, we have such things for modules - https://webpack.js.org/configuration/module/#moduleparserjavascriptdynamicimportpreload, so you can specify it there, just look how it is implemented for preload/prefetch
7. aboktor commented on Apr 14, 2023

   

   aboktor

   on Apr 14, 2023

   ContributorAuthor

   More actions

   @alexander-akait So basically use module.parser.javascript.dynamicImportFetchPriority instead?
8. alexander-akait commented on Apr 14, 2023

   

   alexander-akait

   on Apr 14, 2023

   Member

   More actions

   @aboktor Yeah, so you can apply it in different places, also /* webpackFetchPriority: "high" */ should be supported too
9. TheLarkInn commented on Apr 15, 2023

   

   TheLarkInn

   on Apr 15, 2023

   Member

   More actions

   I'm on board with this. It still applies the "global nature" for dev experience but is customizable at the module rule level and can apply to many module types.

   👍React with 👍2Reacted by Andrew Boktor and Nitin Kumar
10. TheLarkInn

    closed this as completedin #17249on Jun 14, 2023