feat(unicorn): add no-array-reverse rule - #2198
Merged
elecmonkey merged 3 commits intoSep 18, 2026
Merged
Conversation
elecmonkey
reviewed
Sep 17, 2026
Enable unicorn/no-array-reverse at error severity in the existing recommended preset and assert its public preset registration in the existing test suite. Verified the selected source-backed preset test, unchanged sibling settings, upstream severity, formatting, spelling, and diff checks.
elecmonkey
previously approved these changes
Sep 17, 2026
elecmonkey
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Refs #1309.
Port
unicorn/no-array-reversefrom eslint-plugin-unicorn v75.0.0. Verified that the rule was absent from main and exact-name PR searches returned no matches, including immediately before publication.Changes
Array#toReversed()replacements and the upstreamallowExpressionStatementoption (defaulttrue).Verification completed locally
go test ./internal/plugins/unicorn/rules/no_array_reverse ./internal/plugins/unicorn/unicornutil.pnpm run format:check, andgit diff --checkpassed. Normal repository commit hooks remain enabled.Validation not completed locally
The full catalog test reached linking, but the Mac encountered disk pressure and sustained linker memory/I/O pressure. Those full-build jobs were stopped; no catalog-test pass is claimed.
Fresh native/core JavaScript builds, the JavaScript integration mirror, and the additional native-API differential run have not completed locally. The JS mirror is included but is not claimed as passing. CI should validate the native/JavaScript integration before merge.