feat(node): add no-restricted-import rule - #2184
Merged
Merged
Conversation
elecmonkey
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add
node/no-restricted-importto restrict imports and re-exports by module name or resolved file path.Refs #475.
Changes
Validation: scoped Go tests passed on macOS arm64 and Linux arm64, and CI Go tests passed on Linux x64. Native Windows npm integration passed, including all 41 cases in the new rule's upstream/documentation mirror. Locally, four JS integration files have 219 passing tests and 3 existing skips; eight real source files have all 32 diagnostics matching the pinned upstream. Catalog checks, scoped
golangci-lint, builds, formatting (including an independent rule Markdown check), and explicit changed-file spell checks passed. Temporary Go benchmarks were run and are excluded from this PR.Current CI limitations: the Windows Go job hit linker memory exhaustion (
VirtualAlloc, errno 1455) before reaching the affected unit-test packages. GitHub rejected a targeted rerun while the encompassing workflow remains active. The CI spell step failed during installation because the freshly releasedcspell-globdependency does not satisfyminimumReleaseAge; the local changed-file spell check passed.