fix: exit 1 when vitest list fails collection (fix #11145) - #11146
Merged
Merged
Conversation
sheremet-va
approved these changes
Sep 4, 2026
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #11145
vitest listprints a collection error and exits 0 when it parses files statically, the default since #11088.--no-static-parseexits 1 for the same file.Vitest.collect()only sets the exit code in the branch that callscollectTests. This adds the samehasFailedcheck to the static branch. It has to live incollect(), sincestart()also callsparseSpecificationsto filter specifications for a normal run.Tests
#11088 moved the only exit code assertion in
list.test.tsonto--no-static-parse. I added the same cases for the default path. They fail on main withexpected +0 to be 1.I used Claude Code while investigating this. I reproduced the bug and reviewed the fix myself.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
Changesets