fix: make attachmentsDir root only config - #10334
Merged
sheremet-va merged 2 commits intoMay 13, 2026
Merged
sheremet-va merged 2 commits into
sheremet-va merged 2 commits into
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: Codex <noreply@openai.com>
hi-ogawa
marked this pull request as ready for review
May 13, 2026 01:04
AriPerkkio
approved these changes
May 13, 2026
AriPerkkio
left a comment
AriPerkkio
left a comment
Member
There was a problem hiding this comment.
Makes sense to me, as attachments are more like reporter results.
sheremet-va
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
.vitest/attachmentsin each project root and html reporter doesn't serve them #10326This PR fixes all projects to use the root
attachmentsDir. Source paths still resolve from the owning project, but all projects now write into the shared root.vitest/attachmentsdirectory.This is safe for UI and Browser Mode because attachments are served through the dedicated
/__vitest_attachment__middleware, not as project-local Vite static files. The default directory change is again breaking-ish change, but v5 already did that by.vitest-attachments -> .vitest/attachments, so probably fine without special treatment.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.