Skip loadBindings() Lightning CSS check during next start - #91538
Merged
Merged
Conversation
sokra
marked this pull request as ready for review
March 17, 2026 21:47
Contributor
|
Notifying the following users due to files changed in this PR based on this repo's notify modifiers: @timneutkens, @ijjk, @shuding, @huozhi: |
mischnic
approved these changes
Mar 17, 2026
Contributor
Tests Passed |
Contributor
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URL |
lukesandberg
approved these changes
Mar 18, 2026
The capability check is only needed at build time. During PHASE_PRODUCTION_SERVER the app is already built and no CSS compilation occurs, so loading the native SWC binary to check css.lightning support is wasted work. Co-Authored-By: Claude <noreply@anthropic.com>
sokra
force-pushed
the
sokra/no-lightningcss-in-next-start
branch
from
March 19, 2026 07:37
be37fe8 to
42ea8bf
Compare
sokra
enabled auto-merge (squash)
March 19, 2026 08:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid calling
loadBindings()to check whether the loaded binary supports Lightning CSS duringnext start, as this is unnecessary for production server operation. The check should only occur during the build phase.next start(production server phase)Test plan