Skip to content

Fix emscripten CI for Chrome 137+ - #3599

Merged
pquentin merged 10 commits into
urllib3:mainfrom
joemarshall:fix_chrome137
Jun 5, 2025
Merged

pquentin merged 10 commits into
urllib3:mainfrom
joemarshall:fix_chrome137

Conversation

@joemarshall

Copy link
Copy Markdown
Contributor

Fix to the CI errors occurring in Chrome 137 or later, because JSPI is on by default in those browsers.

#3598

@joemarshall

Copy link
Copy Markdown
Contributor Author

@illia-v I think this is ready to go now I got rid of the silly test code in fetch.py

@illia-v

illia-v commented Apr 24, 2025

Copy link
Copy Markdown
Member

@joemarshall thanks for the efforts to fix the CI!
I've reviewed the changes and understand that code of urllib3 (other than tests) is not affected by JSPI becoming default in Chrome. I found some places getting confusing now when an environment can support both JSPI and XHR by default, and I need to spend more time on this next week. Let's use Chrome stable in the meantime

@illia-v

illia-v commented Jun 5, 2025

Copy link
Copy Markdown
Member

On second thought, I'm ready to merge this with a couple of minor changes. There is still some refactoring I'd like to do on top of this, but it can be done separately

@illia-v illia-v added the Skip Changelog Pull requests that don't require a changelog entry label Jun 5, 2025
@illia-v illia-v linked an issue Jun 5, 2025 that may be closed by this pull request

@pquentin pquentin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why we need pyodide.ffi.can_run_sync = lambda: False twice, but it does fix CI.

@pquentin pquentin changed the title fix to CI bug in chrome 137 Fix emscripten CI for Chrome 137+ Jun 5, 2025
@illia-v

illia-v commented Jun 5, 2025

Copy link
Copy Markdown
Member

I don't understand why we need pyodide.ffi.can_run_sync = lambda: False twice, but it does fix CI.

I believe one patches tests using web workers and another for tests running in the main thread

@pquentin
pquentin merged commit 9996e0f into urllib3:main Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog Pull requests that don't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSPI shipping in Chrome 137 breaks CI

3 participants