Skip to content

[UNDERTOW-2312][UNDERTOW-2425][UNDERTOW-2424] Backport fixes - #1653

Merged
fl4via merged 5 commits into
undertow-io:2.3.xfrom
fl4via:backport-fixes_2.3.x
Aug 22, 2024
Merged

fl4via merged 5 commits into
undertow-io:2.3.xfrom
fl4via:backport-fixes_2.3.x

Conversation

@fl4via

@fl4via fl4via commented Aug 22, 2024

Copy link
Copy Markdown
Member

baranowb and others added 5 commits August 22, 2024 05:58
…so: make the test pass on the modes for HTTP2 upgrade and AJP

Signed-off-by: Flavia Rainone <frainone@redhat.com>
Signed-off-by: fl4via <frainone@redhat.com>
…ngs in Http2 upgrade

The  new code caused ALLOW_UNESCAPED_CHARACTERS_IN_URL to not work correctly in HTTP2 upgrade scenarios when the characters are in the query. The reason for that is that Http2UpgradeHandler passes
decode as false when asking Connectors to parse the request path, assuming that otherwise the decode would have been done twice. While that may the true for the parsing of the path, it is not the case when Connectors is parsing query params to set them one-by-one in the HttpServerExchange.This caused LotsOfQueryParametersTestCase to fail when run with HTTP2 Upgrade config.

Signed-off-by: Flavia Rainone <frainone@redhat.com>
…tener = null), prevent the buffer.flip() from not being cleared after an error during attempts to write.

Also, at ServletPrintWriter, verify if no progress is being made when attempting to encode returns overflow after flushing, and mark error even if there are remaining bytes in the buffer.

Signed-off-by: Flavia Rainone <frainone@redhat.com>
…hunkedStreamSinkConduit

ChunkedStreamSinkConduit releases underlying connections for reuse via a
conduit listener, however flush calls may still be passed through
after writes are terminated and successfully flushed. This would cause
requests to be clobbered when the connection had already been reused
to send another request, breaking the threading model.
@fl4via fl4via added waiting CI check Ready to be merged but waiting for CI check backport The PR is the result of backporting another PR to a maintainance branch labels Aug 22, 2024
@fl4via fl4via removed the waiting CI check Ready to be merged but waiting for CI check label Aug 22, 2024
@fl4via
fl4via merged commit 9d49c81 into undertow-io:2.3.x Aug 22, 2024
@fl4via
fl4via deleted the backport-fixes_2.3.x branch August 22, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport The PR is the result of backporting another PR to a maintainance branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants