Skip to content

chore: drop unused tmp - #487

Merged
SukkaW merged 1 commit into
un-ts:masterfrom
SukkaW:drop-tmp
Jun 3, 2026
Merged

chore: drop unused tmp#487
SukkaW merged 1 commit into
un-ts:masterfrom
SukkaW:drop-tmp

Conversation

@SukkaW

@SukkaW SukkaW commented Jun 2, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Closes #485

We don't need a tmp package just for unit testing.

Summary by CodeRabbit

  • Chores
    • Removed an unused development dependency.
  • Tests
    • Updated a test to stop using an external temp library and instead use native OS/temp directory creation and cleanup for the ESLint-related scenario.

@changeset-bot

changeset-bot Bot commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6c21759

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cc53c9ba-df76-4790-a928-2f611d15bae8

📥 Commits

Reviewing files that changed from the base of the PR and between f5e4898 and 6c21759.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • package.json
  • test/rules/no-unused-modules.spec.ts
💤 Files with no reviewable changes (1)
  • package.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • test/rules/no-unused-modules.spec.ts
📝 Walkthrough

Walkthrough

Removed the tmp devDependency and updated a test to create temp directories with fs.mkdtempSync(path.join(os.tmpdir(), ...)), adding os/path imports and removing tmp.dirSync; cleanup now uses fs.rmSync(tempDir, { recursive: true, force: true }).

Changes

Dependency removal and Node API migration

Layer / File(s) Summary
Dependency removal and import refactoring
package.json, test/rules/no-unused-modules.spec.ts		 tmp devDependency removed; test imports updated to add os and path and remove tmp.dirSync import.
Temporary directory creation and cleanup refactoring
test/rules/no-unused-modules.spec.ts		 Temp dir creation now uses fs.mkdtempSync(path.join(os.tmpdir(), ...)); cleanup uses fs.rmSync(tempDir, { recursive: true, force: true }) instead of removeCallback().

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A rabbit pads through tests at night,
Swaps a package for Node's own light,
mkdtemp makes a cozy den,
rmSync clears it—then we're done. 🐇✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR does not meet the objective of issue #485, which requests updating tmp to v0.2.6 for security fixes. Instead, it removes tmp entirely, which is out of scope. Either update tmp to v0.2.6 as specified in #485 to remediate CVE-2025-54798 and CVE-2026-44705, or clarify why complete removal is preferred over patching.
Out of Scope Changes check ⚠️ Warning The changes address dependency cleanup but contradict issue #485, which requires updating tmp for security vulnerabilities, making this scope misalignment problematic. Clarify with the team whether tmp should be removed or updated to v0.2.6. If removal is intentional, confirm it is the correct resolution for the security concerns in #485.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change—removing the unused tmp dependency from devDependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codesandbox-ci

codesandbox-ci Bot commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@pkg-pr-new

pkg-pr-new Bot commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-import-x@487

commit: 6c21759

@codacy-production

codacy-production Bot commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@SukkaW
SukkaW enabled auto-merge (squash) June 2, 2026 08:17
@SukkaW
SukkaW merged commit 96222bf into un-ts:master Jun 3, 2026
54 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JounQin JounQin JounQin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SukkaW @JounQin