fix(ast-spec): narrow import attribute keys to identifiers and strings - #12879

Thanks for the PR, @camc314!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	3f4a20e
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/6aaa2430b1dff60007546764
😎 Deploy Preview	https://deploy-preview-12879--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (no change from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 90 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

View your CI Pipeline Execution ↗ for commit 3f4a20e

☁️ Nx Cloud last updated this comment at 2026-09-16 05:13:06 UTC

Ah I can't stack PRs with forks. I've got another PR to change the value property > camc314#1

Once this is merged, i'll put up that PR.

I've split the two PRs to make the changes, changelog clearer, and to make it easier to review

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.72%. Comparing base (4a742ff) to head (3f4a20e).
⚠️ Report is 10 commits behind head on main.

@@            Coverage Diff             @@
##             main   #12879      +/-   ##
==========================================
- Coverage   94.98%   90.72%   -4.27%     
==========================================
  Files         229      523     +294     
  Lines       11634    17166    +5532     
  Branches     3867     5330    +1463     
==========================================
+ Hits        11051    15573    +4522     
- Misses        251      947     +696     
- Partials      332      646     +314     

Hi @camc314, thanks for the update!

Just a quick heads-up: please try to avoid force-pushing moving forward. Rewriting history makes it harder for us to track incremental changes between reviews.

Since we squash merge anyway, there is no need to keep the commit history "clean" on this branch. Standard pushes are much preferred!

Oops - apologies for the force push.

Can we add a test to validate that we reject the non-string-literal case?

Done - I've only added a single test with a number as the key to avoid a large number of additional tests to cover all literal varients. But if you want more let me know.