Repository navigation
fix(rule-tester): normalize paths before checking if they escape cwd - #11525
JoshuaKGoldberg merged 3 commits into
Conversation
|
Thanks for the PR, @dbarabashh! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 6ff0c5a
☁️ Nx Cloud last updated this comment at |
|
Not very sure if this is the same problem as in the previous PR. But it looks like it is coming from the main branch and needs to be fixed. @JoshuaKGoldberg, @kirkwaiblinger wdyt? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11525 +/- ##
=======================================
Coverage 90.87% 90.87%
=======================================
Files 505 505
Lines 51146 51146
Branches 8424 8424
=======================================
Hits 46480 46480
Misses 4652 4652
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
kirkwaiblinger
left a comment
kirkwaiblinger
left a comment
There was a problem hiding this comment.
Looks good! just requesting a testing tweak
kirkwaiblinger
added
the
1 approval
|
🚀 |
…ypescript-eslint#11525) * fix(rule-tester): normalize paths before checking if they escape cwd * added test cases --------- Co-authored-by: Kirk Waiblinger <53019676+kirkwaiblinger@users.noreply.github.com>
PR Checklist
Overview
Paths like
'./../../file.ts'were not being detected as escaping the current directory because the check only looked for paths starting with'..'. This fix normalizes paths before checking, so paths like'./../'and'./../../'are properly handled.