Skip to content

fix(typescript-estree): improve project service error message when file extension missing from extraFileExtensions - #10076

Merged
JoshuaKGoldberg merged 3 commits into
typescript-eslint:mainfrom
kirkwaiblinger:project-service-extra-file-extension-error
Oct 10, 2024
Merged

fix(typescript-estree): improve project service error message when file extension missing from extraFileExtensions#10076
JoshuaKGoldberg merged 3 commits into
typescript-eslint:mainfrom
kirkwaiblinger:project-service-extra-file-extension-error

Conversation

@kirkwaiblinger

@kirkwaiblinger kirkwaiblinger commented Sep 29, 2024

Copy link
Copy Markdown
Member

PR Checklist

Overview

@typescript-eslint

typescript-eslint Bot commented Sep 29, 2024

Copy link
Copy Markdown
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify

netlify Bot commented Sep 29, 2024 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit e9cab34
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66fa30b5e80e3900088ae69b
😎 Deploy Preview https://deploy-preview-10076--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud

nx-cloud Bot commented Sep 29, 2024 •
edited
Loading

Copy link
Copy Markdown

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e9cab34. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 32 targets

Sent with 💌 from NxCloud.

@codecov

codecov Bot commented Sep 29, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.00%. Comparing base (a916ff2) to head (e9cab34).
Report is 22 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10076      +/-   ##
==========================================
+ Coverage   85.99%   86.00%   +0.01%     
==========================================
  Files         428      428              
  Lines       14912    14923      +11     
  Branches     4332     4335       +3     
==========================================
+ Hits        12823    12834      +11     
  Misses       1744     1744              
  Partials      345      345
Flag Coverage Δ
unittest 86.00% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ee/src/create-program/createProjectProgramError.ts 100.00% <100.00%> (ø)
...ges/typescript-estree/src/create-program/shared.ts 78.57% <100.00%> (+1.07%) ⬆️
...escript-estree/src/useProgramFromProjectService.ts 100.00% <100.00%> (ø)

@kirkwaiblinger
kirkwaiblinger marked this pull request as ready for review September 30, 2024 05:01
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 10, 2024
View reviewed changes

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 awesome!

@JoshuaKGoldberg
JoshuaKGoldberg merged commit 72a13a9 into typescript-eslint:main Oct 10, 2024
@kirkwaiblinger
kirkwaiblinger deleted the project-service-extra-file-extension-error branch October 10, 2024 19:48
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Misleading error when including non standard file types with projectService

2 participants

@kirkwaiblinger @JoshuaKGoldberg