Skip to content

fix(eslint-plugin): [prefer-literal-enum-member] allow nested bitwise operations - #10037

Merged
JoshuaKGoldberg merged 5 commits into
typescript-eslint:mainfrom
kirkwaiblinger:kirk-nested-bitwise
Sep 30, 2024
Merged

fix(eslint-plugin): [prefer-literal-enum-member] allow nested bitwise operations#10037
JoshuaKGoldberg merged 5 commits into
typescript-eslint:mainfrom
kirkwaiblinger:kirk-nested-bitwise

Conversation

@kirkwaiblinger

@kirkwaiblinger kirkwaiblinger commented Sep 23, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

PR Checklist

Overview

just a lil recursion.

The diff looks more complicated than it is due to the conversion to a switch, but I think the new version is much more readable

@typescript-eslint

typescript-eslint Bot commented Sep 23, 2024

Copy link
Copy Markdown
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify

netlify Bot commented Sep 23, 2024 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ae17ba5
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66f9dbfab60f2b0008645381
😎 Deploy Preview https://deploy-preview-10037--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud

nx-cloud Bot commented Sep 23, 2024 •
edited
Loading

Copy link
Copy Markdown

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ae17ba5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 32 targets

Sent with 💌 from NxCloud.

@kirkwaiblinger
kirkwaiblinger marked this pull request as ready for review September 23, 2024 01:15
@codecov

codecov Bot commented Sep 23, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.01%. Comparing base (a916ff2) to head (ae17ba5).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10037      +/-   ##
==========================================
+ Coverage   85.99%   86.01%   +0.02%     
==========================================
  Files         428      428              
  Lines       14912    14910       -2     
  Branches     4332     4327       -5     
==========================================
+ Hits        12823    12825       +2     
+ Misses       1744     1741       -3     
+ Partials      345      344       -1
Flag Coverage Δ
unittest 86.01% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...int-plugin/src/rules/prefer-literal-enum-member.ts 100.00% <100.00%> (+9.52%) ⬆️

@kirkwaiblinger kirkwaiblinger added the bug Something isn't working label Sep 23, 2024
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Sep 23, 2024
View reviewed changes

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 23, 2024
kirkwaiblinger
kirkwaiblinger commented Sep 23, 2024
View reviewed changes
Comment thread packages/eslint-plugin/src/rules/prefer-literal-enum-member.ts Outdated
@JoshuaKGoldberg
JoshuaKGoldberg merged commit 977e0a1 into typescript-eslint:main Sep 30, 2024
@kirkwaiblinger
kirkwaiblinger deleted the kirk-nested-bitwise branch September 30, 2024 14:07
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

Assignees

No one assigned

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhancement: [prefer-literal-enum-member] Allow nested bitwise when using the allowBitwiseExpressions option

2 participants

@kirkwaiblinger @JoshuaKGoldberg