Skip to content

*: add CLI arguments to configure TLS ciphers for gRPC servers + remote-write receiver's server - #8730

Merged
saswatamcode merged 6 commits into
thanos-io:mainfrom
simonpasquier:ciphers-for-grpc-server
Apr 14, 2026
Merged

saswatamcode merged 6 commits into
thanos-io:mainfrom
simonpasquier:ciphers-for-grpc-server

Conversation

@simonpasquier

Copy link
Copy Markdown
Contributor
  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Related to #8685

  • Extend NewServerConfig() to configure TLS ciphers
  • Add --grpc-server-tls-ciphers CLI argument to configure gRPC servers.
  • Add --remote-write.server-tls-ciphers CLI arguments to configure the remote-write receiver server.

Verification

Unit + end-to-end tests added.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@simonpasquier
simonpasquier force-pushed the ciphers-for-grpc-server branch from 44c40a1 to 4ef5f20 Compare March 25, 2026 15:15
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
This commit adds an end-to-end test ensuring correct behaviour
when a client establishes a TLS connection to a server.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@simonpasquier
simonpasquier force-pushed the ciphers-for-grpc-server branch from 4ef5f20 to 6d3c3f5 Compare March 25, 2026 15:41
@simonpasquier

Copy link
Copy Markdown
Contributor Author

cc @saswatamcode

@simonpasquier simonpasquier changed the title *: add CLI arguments to configureTLS ciphers for gRPC servers + remote-write receiver's server *: add CLI arguments to configure TLS ciphers for gRPC servers + remote-write receiver's server Mar 30, 2026

@saswatamcode saswatamcode left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saswatamcode
saswatamcode merged commit d90e7d3 into thanos-io:main Apr 14, 2026
20 of 22 checks passed
@simonpasquier
simonpasquier deleted the ciphers-for-grpc-server branch April 14, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants