mock: Call.Unset panics

Hi team, I'm using testify to testing my method but encounter this issue (It only occur if using matchedBy arg)
When I using mock following by example but got error when using mockCall.Unset().
playground: https://go.dev/play/p/oQ2sGSRCtbR

Fix for stretchr#1236

Fix Call.Unset() panic (issue stretchr#1236)

I've got the same trouble :(
Could you check and may be vote for my fix for this?
#1250

Fix Call.Unset() panic (issue stretchr#1236)

For people who face this issue, i use this code

	unset := func(call *mock.Call) {
		if call != nil {
			call.Parent.ExpectedCalls = []*mock.Call{}
		}
	}
	var caller *mock.Call
	unset(caller)

as temporary fix. you can try this to

@at-syot

Just fyi, I put short snippet which only specific method would be deleted based on @at-syot 's code

var unsetFn = func(call *mock.Call) {
	if call != nil {
		var newList []*mock.Call
		for _, c := range call.Parent.ExpectedCalls {
			if c.Method != call.Method {
				newList = append(newList, c)
			}
		}
		call.Parent.ExpectedCalls = newList
	}
}

// caller side
unsetFn(mockInstance.On("SOME_METHOD_YOU_WANT_TO_UNSET"))

@gordonlee

Hello @gordonlee .
I have a fix #1250 but have no permission merge it.
Could you help promote it?

Running in the same problem. A fix would be appreciated 😄

Fix Call.Unset() panic (issue #1236) (#1250)

merge: deps: update module github.com/stretchr/testify to v1.9.0

Navigation Menu

Repository navigation

mock: Call.Unset panics #1236

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

mock: Call.Unset panics #1236

Description

Activity

lisitsky commented on Aug 15, 2022

at-syot commented on Nov 17, 2022

gordonlee commented on Dec 5, 2022

lisitsky commented on Dec 5, 2022

hugoboos commented on Dec 14, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions