Skip to content

React Native: Remove watcher from init - #25895

Merged
shilman merged 1 commit into
nextfrom
dannyhw/adjust-rn-init
Feb 3, 2024
Merged

shilman merged 1 commit into
nextfrom
dannyhw/adjust-rn-init

Conversation

@dannyhw

@dannyhw dannyhw commented Feb 3, 2024 •

Copy link
Copy Markdown
Member

Closes #

What I did

Removed the watcher from the initialisation script template since its not longer needed.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@dannyhw dannyhw added maintenance User-facing maintenance tasks ci:normal Run our default set of CI jobs (choose this for most PRs). labels Feb 3, 2024
@dannyhw
dannyhw requested a review from shilman February 3, 2024 22:14

@shilman shilman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman added react-native cli patch:yes Bugfix & documentation PR that need to be picked to main branch labels Feb 3, 2024
@shilman
shilman merged commit 39cc4da into next Feb 3, 2024
@shilman
shilman deleted the dannyhw/adjust-rn-init branch February 3, 2024 23:54
storybook-bot pushed a commit that referenced this pull request Feb 3, 2024
storybook-bot pushed a commit that referenced this pull request Feb 5, 2024
storybook-bot pushed a commit that referenced this pull request Feb 5, 2024
storybook-bot pushed a commit that referenced this pull request Feb 5, 2024
storybook-bot pushed a commit that referenced this pull request Feb 5, 2024
storybook-bot pushed a commit that referenced this pull request Feb 5, 2024
storybook-bot pushed a commit that referenced this pull request Feb 6, 2024
storybook-bot pushed a commit that referenced this pull request Feb 6, 2024
storybook-bot pushed a commit that referenced this pull request Feb 6, 2024
storybook-bot pushed a commit that referenced this pull request Feb 6, 2024
@github-actions github-actions Bot mentioned this pull request Feb 6, 2024
8 tasks
@github-actions github-actions Bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 6, 2024
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:normal Run our default set of CI jobs (choose this for most PRs). cli maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch react-native

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants