Fixed invariant violation in MemBio::get_buf with empty results - #2266
Merged
Merged
Conversation
Pointer arguments to `slice::from_raw_parts` are required to be non-null. (See https://davidben.net/2024/01/15/empty-slices.html for details.)
sfackler
approved these changes
Jul 21, 2024
This was referenced Jul 22, 2024
Closed
Closed
doitian
pushed a commit
to doitian/ckb
that referenced
this pull request
Jul 22, 2024
```
error[vulnerability]: `MemBio::get_buf` has undefined behavior with empty buffers
┌─ /home/runner/work/ckb/ckb/Cargo.lock:313:1
│
313 │ openssl 0.10.64 registry+https://github.com/rust-lang/crates.io-index
│ --------------------------------------------------------------------- security vulnerability detected
│
= ID: RUSTSEC-2024-0357
= Advisory: https://rustsec.org/advisories/RUSTSEC-2024-0357
= Previously, `MemBio::get_buf` called `slice::from_raw_parts` with a null-pointer, which violates the functions invariants, leading to undefined behavior. In debug builds this would produce an assertion failure. This is now fixed.
= Announcement: rust-openssl/rust-openssl#2266
= Solution: Upgrade to >=0.10.66 (try `cargo update -p openssl`)
```
Desiki-high
added a commit
to Desiki-high/nydus
that referenced
this pull request
Jul 22, 2024
```
error[vulnerability]: `MemBio::get_buf` has undefined behavior with empty buffers
┌─ /home/runner/work/ckb/ckb/Cargo.lock:313:1
│
313 │ openssl 0.10.64 registry+https://github.com/rust-lang/crates.io-index
│ --------------------------------------------------------------------- security vulnerability detected
│
= ID: RUSTSEC-2024-0357
= Advisory: https://rustsec.org/advisories/RUSTSEC-2024-0357
= Previously, `MemBio::get_buf` called `slice::from_raw_parts` with a null-pointer, which violates the functions invariants, leading to undefined behavior. In debug builds this would produce an assertion failure. This is now fixed.
= Announcement: rust-openssl/rust-openssl#2266
= Solution: Upgrade to >=0.10.66 (try `cargo update -p openssl`)
```
Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Desiki-high
added a commit
to Desiki-high/nydus
that referenced
this pull request
Jul 22, 2024
```
┌─ /github/workspace/Cargo.lock:148:1
│
148 │ openssl 0.10.55 registry+https://github.com/rust-lang/crates.io-index
│ --------------------------------------------------------------------- security vulnerability detected
│
= ID: RUSTSEC-2024-0357
= Advisory: https://rustsec.org/advisories/RUSTSEC-2024-0357
= Previously, `MemBio::get_buf` called `slice::from_raw_parts` with a null-pointer, which violates the functions invariants, leading to undefined behavior. In debug builds this would produce an assertion failure. This is now fixed.
= Announcement: rust-openssl/rust-openssl#2266
= Solution: Upgrade to >=0.10.66 (try `cargo update -p openssl`)
```
Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
doitian
pushed a commit
to doitian/ckb-cli
that referenced
this pull request
Jul 22, 2024
```
error[vulnerability]: `MemBio::get_buf` has undefined behavior with empty buffers
┌─ /home/runner/work/ckb/ckb/Cargo.lock:313:1
│
313 │ openssl 0.10.64 registry+https://github.com/rust-lang/crates.io-index
│ --------------------------------------------------------------------- security vulnerability detected
│
= ID: RUSTSEC-2024-0357
= Advisory: https://rustsec.org/advisories/RUSTSEC-2024-0357
= Previously, `MemBio::get_buf` called `slice::from_raw_parts` with a null-pointer, which violates the functions invariants, leading to undefined behavior. In debug builds this would produce an assertion failure. This is now fixed.
= Announcement: rust-openssl/rust-openssl#2266
= Solution: Upgrade to >=0.10.66 (try `cargo update -p openssl`)
```
This was referenced Jul 23, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pointer arguments to
slice::from_raw_partsare required to be non-null. (See https://davidben.net/2024/01/15/empty-slices.html for details.)