Repository navigation
Support shared futures on no_std - #2868
Merged
Merged
Conversation
Member
|
Thanks for the PR. I would prefer not to use spinlock by default around operations that would involve allocations even if it is no_std-only. That said, it might be fine if this is an optional feature and spinlock is used only when std is disabled and the feature is explicitly enabled. |
taiki-e
added
S-waiting-on-author
Contributor
Author
|
I moved the spinlock behind an optional |
taiki-e
reviewed
Jan 12, 2025
taiki-e
reviewed
Jan 12, 2025
taiki-e
added
0.3-backport: pending
taiki-e
pushed a commit
that referenced
this pull request
Feb 15, 2026
Merged
taiki-e
added
0.3-backport: completed
and removed
0.3-backport: pending
taiki-e
pushed a commit
that referenced
this pull request
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
Sharedfutures are only available when thestdfeature is enabled because they usestd::sync::Mutexinternally. This PR changes this so thatSharedfutures will fall back to using a spinlock whenstdis not enabled.Alternatively,
Sharedcould be changed to be generic over a mutex trait (e.g.lock_api::RawMutex, though it isn't implemented forstd::sync::Mutex) to allow arbitrary user implementations.