Repository navigation
Option "mapFallbackValue" ignored when inherited to subcommand #2035
Description
With an @option defined like this:
@Command(
name = "main"
subcommands = {
SubCmd.class,
CommandLine.HelpCommand.class
}
)
public class Main {
@Option(
names = "-D",
paramLabel = "<key=value>",
mapFallbackValue = Option.NULL_VALUE,
scope = ScopeType.INHERIT
)
private final Map<String, String> javaOpts = new HashMap<>();
}
@Command(name = "sub")
public class SubCmd {
@ParentCommand
private Main parent;
}Running with args like ["sub", "-Dxyz"] results in error message:
Value for option option '-D' (<key=value>) should be in KEY=VALUE format but was xyz
This seems like it might be because the ArgSpec Builder copy constructor doesn't copy the "mapFallbackValue" field in picocli 4.7.3: https://github.com/remkop/picocli/blob/v4.7.3/src/main/java/picocli/CommandLine.java#L9496
Activity
remkop commentedon Jun 1, 2023
Thank you for raising this, and thank you for the analysis!
It’s very plausible that that’s the cause.
Will you be able to provide a pull request for this?
Fixes remkop#2035 - include mapFallbackValue for inherited opts
zman0900 commentedon Jun 1, 2023
PR #2036 opened
Fixes #2035 - include mapFallbackValue for inherited opts
[#2026][#2027][#2029][#2034][#2035][#2036][#1848][#2030] update RELEA…