Repository navigation
Updating INCREX command arg - SATURATE now controls overflow behaviour - #4077
Merged
Merged
Conversation
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3ae9345. Configure here.
elena-kolevska
approved these changes
May 27, 2026
petyaslavova
added a commit
that referenced
this pull request
May 28, 2026
#4077) * Updating INCREX command arg - SATURATE now controls overflow behaviour * Fixing flaky test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Please provide a description of the change here.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Note
Medium Risk
Public API change on increx (breaking for overflow= callers) and different error vs return behavior on bound violations; otherwise test and CI wiring.
Overview
increxis aligned with the updated Redis command: theoverflowstring option (FAIL/REJECT/SAT) is replaced by a booleansaturatethat emits theSATURATEwire flag when true. Docs and validation for invalid overflow values are removed accordingly.Default out-of-bounds behavior no longer raises
ResponseErroron the client; rejected increments return[current_value, 0]and leave the key (and TTL) unchanged. Tests were renamed/extended for that semantics, including integer type-limit cases withsaturate=Trueon the sync path.CI runs Redis 8.8 against a custom Debian image instead of
8.8-rc1. Async pub/subtest_late_subscribecallsconnect()beforerun()to avoid a CI race instead of polling for connection readiness.Reviewed by Cursor Bugbot for commit 8a4a764. Bugbot is set up for automated code reviews on this repo. Configure here.