Skip to content

doc: Clarify capturing .readouterr() return value - #13222

Merged
The-Compiler merged 1 commit into
pytest-dev:mainfrom
The-Compiler:doc-capturing
Feb 15, 2025
Merged

doc: Clarify capturing .readouterr() return value#13222
The-Compiler merged 1 commit into
pytest-dev:mainfrom
The-Compiler:doc-capturing

Conversation

@The-Compiler

@The-Compiler The-Compiler commented Feb 13, 2025

Copy link
Copy Markdown
Member

This got added in 38fb6aa, where the "The return value ... changed" made a lot of sense. However, 9c5da9c removed the "versionadded" without adjusting the wording.

Also see 3a4435f.

@The-Compiler
doc: Clarify capturing .readouterr() return value
18271cd 
This got added in 38fb6aa, where the "The
return value ... changed" made a lot of sense. However,
9c5da9c removed the "versionadded" without
adjusting the wording.

Also see 3a4435f.
The-Compiler
The-Compiler commented Feb 13, 2025
View reviewed changes
Comment thread doc/en/how-to/parametrize.rst


Several improvements.

@The-Compiler The-Compiler Feb 13, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another leftover I noticed when reviewing the original commit. I think it got hidden as a comment because it's intended under the .. regendoc: wipe.

@The-Compiler The-Compiler added skip news used on prs to opt out of the changelog requirement backport 8.3.x labels Feb 13, 2025
nicoddemus
nicoddemus approved these changes Feb 13, 2025
View reviewed changes

@nicoddemus nicoddemus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@The-Compiler
The-Compiler merged commit 62aa427 into pytest-dev:main Feb 15, 2025
@patchback

patchback Bot commented Feb 15, 2025 •
edited
Loading

Copy link
Copy Markdown

Backport to 8.3.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/8.3.x/62aa4272229a4e604582db534796df1a729b4752/pr-13222

Backported as #13225

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback Bot pushed a commit that referenced this pull request Feb 15, 2025
@The-Compiler @patchback
doc: Clarify capturing .readouterr() return value (#13222)
bb628b7 
This got added in 38fb6aa, where the "The
return value ... changed" made a lot of sense. However,
9c5da9c removed the "versionadded" without
adjusting the wording.

Also see 3a4435f.

(cherry picked from commit 62aa427)
@patchback patchback Bot mentioned this pull request Feb 15, 2025
Merged
The-Compiler added a commit that referenced this pull request Feb 15, 2025
@patchback @The-Compiler
doc: Clarify capturing .readouterr() return value (#13222) (#13225)
edbfff7 
This got added in 38fb6aa, where the "The
return value ... changed" made a lot of sense. However,
9c5da9c removed the "versionadded" without
adjusting the wording.

Also see 3a4435f.

(cherry picked from commit 62aa427)

Co-authored-by: Florian Bruhin <me@the-compiler.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees

No one assigned

Labels

skip news used on prs to opt out of the changelog requirement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@The-Compiler @nicoddemus