Repository navigation
馃懛 ci(upgrade): pass base to create-pull-request - #3320
Merged
Merged
Conversation
The publish job checks out github.sha so it runs the trusted generator revision, which leaves HEAD detached. create-pull-request cannot infer the base branch from a detached HEAD and fails before opening the PR, so the daily upgrade run has stopped producing PRs. Fixes pypa#3319
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daily
Upgrade embedded dependenciesworkflow generates its patch and then fails atCreate Pull Request, as in run 36122624310:When the repository is checked out on a commit instead of a branch, the 'base' input must be supplied.馃悰 The publish job checks outgithub.shaso it runs the trusted generator revision, which leaves HEAD detached, andpeter-evans/create-pull-requestcannot infer a base branch from that state.Passing
base: mainkeeps the checkout pinned to the event commit and gives the action its target branch, as @glaziermag proposed in #3319. Fixes #3319.