Repository navigation
fix: raise correct exception on invalid license - #1219
Merged
Merged
Conversation
facutuesca
force-pushed
the
ft/raise-invalid-license
branch
from
June 4, 2026 14:09
2036029 to
9cf619e
Compare
facutuesca
force-pushed
the
ft/raise-invalid-license
branch
from
June 6, 2026 00:20
9cf619e to
1d27872
Compare
henryiii
approved these changes
Jun 11, 2026
henryiii
left a comment
henryiii
left a comment
Contributor
There was a problem hiding this comment.
This looks correct according to the spec.
Contributor
|
We've removed the requirement that branches be updated (using the newer "always suggest updating" setting instead, so I can now merge without waiting for a synchronized rebase. :) |
henryiii
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SPDX license spec says that a valid
license-idcan have a+suffix:But this does not apply to
license-ref:Currently, during canocalization, if we encounter
LicenseRef-Foo+, we get an unhandledKeyErrorexception. This PR fixes that by instead checking for a suffix and raising the correctInvalidLicenseExpressionexception instead.cc @miketheman