Repository navigation
fix(pylock): add PylockSelectError to __all__ - #1202
Merged
henryiii merged 1 commit intoMay 29, 2026
Merged
Conversation
sbidoul
approved these changes
May 29, 2026
sbidoul
left a comment
sbidoul
left a comment
Member
There was a problem hiding this comment.
That exception is indeed meant to be public.
The PR description could have been one line too, but 🤷 I guess.
henryiii
approved these changes
May 29, 2026
Contributor
|
Even the branch name is longer than the change. :) Thanks! |
henryiii
force-pushed
the
oss-pylock-select-error-export-1092
branch
from
May 29, 2026 13:33
118f062 to
606367e
Compare
henryiii
enabled auto-merge (squash)
May 29, 2026 13:34
henryiii
force-pushed
the
oss-pylock-select-error-export-1092
branch
from
May 29, 2026 14:11
606367e to
d3879db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PylockSelectErroris defined insrc/packaging/pylock.py:313(base exception forPylock.selecterrors with_DefaultSelectionError,_AmbiguousMatchError,_NoMatchErrorsubclasses) and is publicly documented indocs/pylock.rst(.. autoexception:: PylockSelectError, alongside the other Pylock exceptions). Its sibling base exceptions are both already inpackaging.pylock.__all__:PylockValidationError— base, has subclass_PylockRequiredKeyError, also subclassed byPylockUnsupportedVersionErrorPylockUnsupportedVersionError— derives fromPylockValidationErrorAdding
"PylockSelectError"to__all__(alphabetically betweenPylockandPylockUnsupportedVersionError) makes the export surface consistent with the docs and with the established sibling pattern: documented base exceptions go in__all__. Star-imports (from packaging.pylock import *) then expose the three Pylock exceptions uniformly, and downstream introspection (type-stub generation, doc tooling, error-handler scaffolds) sees a uniform shape.Single-line change. No behavioral change.