Use absolute path for {project} placeholder in config-settings - #2934
Merged
agriyakhetarpal merged 1 commit intoJun 30, 2026
Merged
agriyakhetarpal merged 1 commit into
agriyakhetarpal merged 1 commit into
Conversation
agriyakhetarpal
requested review from
freakboy3742,
hoodmane,
mhsmith and
ryanking13
as code owners
June 28, 2026 19:51
agriyakhetarpal
added a commit
to agriyakhetarpal/hugo-python-distributions
that referenced
this pull request
Jun 28, 2026
freakboy3742
left a comment
freakboy3742
left a comment
Contributor
There was a problem hiding this comment.
From an iOS perspective, I don't see any problem with this; explicit full paths are generally safer, as long as we're not dealing with something that will be running on the simulator (which will only be for testing paths).
mhsmith
reviewed
Jun 30, 2026
mhsmith
left a comment
mhsmith
left a comment
Member
There was a problem hiding this comment.
The Android changes look good to me.
henryiii
approved these changes
Jun 30, 2026
agriyakhetarpal
deleted the
use-absolute-path-config-settings-placeholders
branch
June 30, 2026 12:39
agriyakhetarpal
added a commit
to agriyakhetarpal/hugo-python-distributions
that referenced
this pull request
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the
project="."pattern is consistent across all platforms and all our build stages, it's specifically incorrect forconfig-settings, because that value is passed topython -m buildand consumed by the build backend, which may run from a different CWD. It's better to pass the absolute path to the project root inprepare_config_settingsin this case. This only failed on Windows and macOS, as{project}on Linux was always absolute (we set it as/projectvia the container there).I think we should add a test or something for this, but I'm not sure what would be best. Should I add a project that cross-compiles a wheel using a Meson cross file (like I use this functionality)? Or perhaps
test/test_projects/meson.pycan stay as is, but I add a--native-filesince it's resolved the same way a cross file is?xref #2827