Merged
Conversation
agriyakhetarpal
approved these changes
May 2, 2026
Co-authored-by: agriya khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
henryiii
reviewed
May 4, 2026
| Platform-specific environment variables are also available:<br/> | ||
| `CIBW_BEFORE_BUILD_MACOS` | `CIBW_BEFORE_BUILD_WINDOWS` | `CIBW_BEFORE_BUILD_LINUX` | `CIBW_BEFORE_BUILD_ANDROID` | `CIBW_BEFORE_BUILD_IOS` | `CIBW_BEFORE_BUILD_PYODIDE` | ||
|
|
||
| In configuration files, use platform tables like `[tool.cibuildwheel.macos]`. |
Contributor
There was a problem hiding this comment.
Why do we have this note here but not on every other config option? (Maybe the argument is that this one is more likely to need per-platform config?)
Comment on lines
+822
to
+827
| # Use a different command on a specific platform | ||
| [tool.cibuildwheel.linux] | ||
| before-build = "python scripts/install-linux-deps.py" | ||
|
|
||
| [tool.cibuildwheel.macos] | ||
| before-build = "python scripts/install-macos-deps.py" |
Contributor
There was a problem hiding this comment.
We usually keep the config settings and environment settings tabs matching. We should have these examples there too, I think.
Contributor
Author
|
Thanks, pushed ea0cb64 to add the matching env-var examples and kept the shorter config note from the earlier suggestion. Checked git diff --check locally; pre-commit also got through the markdown hooks, but cog hit a Windows encoding issue while reading README/changelog, so I left that as local-only. |
henryiii
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1578.
This adds a short note that pyproject.toml uses platform tables for platform-specific options, and includes 锟絜fore-build examples for Linux and macOS.
Checked with:
git diff --checkpython -m cibuildwheel --helpI also tried
mkdocs build --stricton Windows, but the docs macro calls thecibuildwheelconsole script without.exe, and the local Windows subprocess lookup failed before rendering the page.