Repository navigation
fix: util.move_file shall not use log.notice - #1862
Merged
Merged
Conversation
Using `log.notice` result in many unwanted annotations, at least in GitHub Actions. If we want to print some information about a specific file being moved, it shall be done by the caller - or adding an option to the function - and use `print`.
henryiii
approved these changes
Jun 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
log.noticeresult in many unwanted annotations, at least in GitHub Actions.If we want to print some information about a specific file being moved, it shall be done by the caller - or adding an option to the function - and use
print.