Repository navigation
fix(setup.py): look inside if name == main block - #1613
Merged
Merged
Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
joerick
approved these changes
Sep 18, 2023
joerick
left a comment
joerick
left a comment
Contributor
There was a problem hiding this comment.
ASTs are kinda fun, so, yeah, i'm happy with it :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1611. We could slide down a slippery slope here, but this one is common and simple (vs. supporting
**kwargsor something like that). And the code will look a lot better once we drop Python 3.9 from our runners in a few years.