Repository navigation
Add Gleam lexer - #2662
Merged
Merged
Add Gleam lexer#2662
Conversation
Contributor
|
(Pushed a commit to fix line endings, can you configure Git's core.autocrlf for the future? Thanks.) |
Contributor
Author
Thank you, I thought I'd fixed them. Sorry for the inconvenience |
Anteru
requested changes
Mar 24, 2024
jeanas
requested changes
Mar 29, 2024
| (r'[a-zA-Z_/]\w*', Name), | ||
|
|
||
| # numbers | ||
| (r'(\d+((_\d+)+)?\.(?!\.)(\d+((_\d+)+)?)?|\.\d+((_\d+)+)?)([eEf][+-]?[0-9]+)?', Number.Float), |
Contributor
There was a problem hiding this comment.
Suggested change
| (r'(\d+((_\d+)+)?\.(?!\.)(\d+((_\d+)+)?)?|\.\d+((_\d+)+)?)([eEf][+-]?[0-9]+)?', Number.Float), | |
| (r'(\d+(_\d+)*\.(?!\.)(\d+(_\d+)*)?|\.\d+(_\d+)*)([eEf][+-]?[0-9]+)?', Number.Float), |
(X+)? is just X*.
|
|
||
| # numbers | ||
| (r'(\d+((_\d+)+)?\.(?!\.)(\d+((_\d+)+)?)?|\.\d+((_\d+)+)?)([eEf][+-]?[0-9]+)?', Number.Float), | ||
| (r'\d+((_\d+)+)?[eEf][+-]?[0-9]+', Number.Float), |
Contributor
There was a problem hiding this comment.
Suggested change
| (r'\d+((_\d+)+)?[eEf][+-]?[0-9]+', Number.Float), | |
| (r'\d+(_\d+)*[eEf][+-]?[0-9]+', Number.Float), |
| # numbers | ||
| (r'(\d+((_\d+)+)?\.(?!\.)(\d+((_\d+)+)?)?|\.\d+((_\d+)+)?)([eEf][+-]?[0-9]+)?', Number.Float), | ||
| (r'\d+((_\d+)+)?[eEf][+-]?[0-9]+', Number.Float), | ||
| (r'0[xX][a-fA-F0-9]+((_[a-fA-F0-9]+)+)?(\.([a-fA-F0-9]+((_[a-fA-F0-9]+)+)?)?)?p[+-]?\d+', Number.Float), |
Contributor
There was a problem hiding this comment.
Suggested change
| (r'0[xX][a-fA-F0-9]+((_[a-fA-F0-9]+)+)?(\.([a-fA-F0-9]+((_[a-fA-F0-9]+)+)?)?)?p[+-]?\d+', Number.Float), | |
| (r'0[xX][a-fA-F0-9]+(_[a-fA-F0-9]+)*(\.([a-fA-F0-9]+(_[a-fA-F0-9]+)*)?)?p[+-]?\d+', Number.Float), |
| (r'(\d+((_\d+)+)?\.(?!\.)(\d+((_\d+)+)?)?|\.\d+((_\d+)+)?)([eEf][+-]?[0-9]+)?', Number.Float), | ||
| (r'\d+((_\d+)+)?[eEf][+-]?[0-9]+', Number.Float), | ||
| (r'0[xX][a-fA-F0-9]+((_[a-fA-F0-9]+)+)?(\.([a-fA-F0-9]+((_[a-fA-F0-9]+)+)?)?)?p[+-]?\d+', Number.Float), | ||
| (r'0[bB][01]+((_[01]+)+)?', Number.Bin), |
Contributor
There was a problem hiding this comment.
Suggested change
| (r'0[bB][01]+((_[01]+)+)?', Number.Bin), | |
| (r'0[bB][01]+(_[01]+)*', Number.Bin), |
| (r'\d+((_\d+)+)?[eEf][+-]?[0-9]+', Number.Float), | ||
| (r'0[xX][a-fA-F0-9]+((_[a-fA-F0-9]+)+)?(\.([a-fA-F0-9]+((_[a-fA-F0-9]+)+)?)?)?p[+-]?\d+', Number.Float), | ||
| (r'0[bB][01]+((_[01]+)+)?', Number.Bin), | ||
| (r'0[oO][0-7]+((_[0-7]+)+)?', Number.Oct), |
Contributor
There was a problem hiding this comment.
Suggested change
| (r'0[oO][0-7]+((_[0-7]+)+)?', Number.Oct), | |
| (r'0[oO][0-7]+(_[0-7]+)*', Number.Oct), |
| (r'0[xX][a-fA-F0-9]+((_[a-fA-F0-9]+)+)?(\.([a-fA-F0-9]+((_[a-fA-F0-9]+)+)?)?)?p[+-]?\d+', Number.Float), | ||
| (r'0[bB][01]+((_[01]+)+)?', Number.Bin), | ||
| (r'0[oO][0-7]+((_[0-7]+)+)?', Number.Oct), | ||
| (r'0[xX][a-fA-F0-9]+((_[a-fA-F0-9]+)+)?', Number.Hex), |
Contributor
There was a problem hiding this comment.
Suggested change
| (r'0[xX][a-fA-F0-9]+((_[a-fA-F0-9]+)+)?', Number.Hex), | |
| (r'0[xX][a-fA-F0-9]+(_[a-fA-F0-9]+)*', Number.Hex), |
| (r'0[bB][01]+((_[01]+)+)?', Number.Bin), | ||
| (r'0[oO][0-7]+((_[0-7]+)+)?', Number.Oct), | ||
| (r'0[xX][a-fA-F0-9]+((_[a-fA-F0-9]+)+)?', Number.Hex), | ||
| (r'\d+((_\d+)+)?', Number.Integer), |
Contributor
There was a problem hiding this comment.
Suggested change
| (r'\d+((_\d+)+)?', Number.Integer), | |
| (r'\d+(_\d+)*', Number.Integer), |
Contributor
Author
There was a problem hiding this comment.
This and other suggestions have been implemented, thanks for the input
Contributor
Author
Yep, I'll pick up the requested changes in the next few days. Just been busy with other things. |
Collaborator
|
Merged, thanks! |
|
Just wanted to give you guys a heads up that the documentation on your website states that Gleam support was added in 2.18, but it appears here that it is planned for 2.19. Thanks a lot for all your hard work and looking forward to the next release :) |
Collaborator
|
That's fixed as well now, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this PR adds a lexer for Gleam, which just released version
1.0.0.I've run tests and things look good to me. However, I'm not a Python person and haven't tried writing a lexer before, particularly not one for Pygments, so I'm happy to take feedback and suggestions for improvements.
There is some example HTML at https://red-rose.com/gleam.html that I generated with
pygmentizeand then modified to add thelightbulbstyle (slightly modified for Name colours). This is the same large example file that's included with the PR.Cheers,
Daren