Skip to content

Fix model equality when using runtime extra configuration - #13062

Merged
Viicos merged 4 commits into
mainfrom
vp/extra-eq
Apr 10, 2026
Merged

Viicos merged 4 commits into
mainfrom
vp/extra-eq

Conversation

@Viicos

@Viicos Viicos commented Apr 10, 2026 •

Copy link
Copy Markdown
Member

Change Summary

Fixes #13051.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@Viicos Viicos added the relnotes-fix Used for bugfixes. label Apr 10, 2026
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Apr 10, 2026 •

Copy link
Copy Markdown

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: a4cd5fa
Status: ✅  Deploy successful!
Preview URL: https://75bb46d6.pydantic-docs.pages.dev
Branch Preview URL: https://vp-extra-eq.pydantic-docs.pages.dev

View logs

@codspeed

codspeed Bot commented Apr 10, 2026 •

Copy link
Copy Markdown

Merging this PR will improve performance by 6.2%

⚡ 1 improved benchmark
✅ 214 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ test_list_of_strs_json_uncached 454.5 µs 428 µs +6.2%

Comparing vp/extra-eq (a4cd5fa) with main (17a35e3)

Open in CodSpeed

@github-actions

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic
  main.py
Project Total  

This report was generated by python-coverage-comment-action

@Viicos
Viicos enabled auto-merge (squash) April 10, 2026 17:54
@Viicos
Viicos merged commit b1bf194 into main Apr 10, 2026
82 checks passed
@Viicos
Viicos deleted the vp/extra-eq branch April 10, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overriding extra causes BaseModel equality to fail

2 participants