Skip to content

Skip dependencies not needed on Emscripten - #1114

Merged
Kludex merged 1 commit into
pydantic:mainfrom
hoodmane:skip-deps-for-emscripten
Aug 6, 2026
Merged

Kludex merged 1 commit into
pydantic:mainfrom
hoodmane:skip-deps-for-emscripten

Conversation

@hoodmane

@hoodmane hoodmane commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

Review in cubic

@hoodmane
hoodmane force-pushed the skip-deps-for-emscripten branch from fb0cd6d to 6be9a2d Compare August 5, 2026 22:15
@hoodmane
hoodmane force-pushed the skip-deps-for-emscripten branch from 6be9a2d to 7eabaf2 Compare August 5, 2026 22:16
@hoodmane hoodmane changed the title Skip most dependencies for Emscripten Skip dependencies not needed on Emscripten Aug 5, 2026
@codspeed

codspeed Bot commented Aug 5, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 15 untouched benchmarks
⏩ 7 skipped benchmarks1


Comparing hoodmane:skip-deps-for-emscripten (7eabaf2) with main (5d9eedc)

Open in CodSpeed

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@hoodmane hoodmane mentioned this pull request Aug 5, 2026
3 tasks done

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed against the latest diff

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/httpx2/pyproject.toml
@Kludex
Kludex merged commit e52f963 into pydantic:main Aug 6, 2026
14 checks passed
@hoodmane
hoodmane deleted the skip-deps-for-emscripten branch August 6, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants