Repository navigation
Improve AST safety check - #4290
Merged
Merged
Conversation
hauntsaninja
force-pushed
the
ast-safety
branch
from
March 22, 2024 18:38
c89a143 to
5cfc118
Compare
hauntsaninja
force-pushed
the
ast-safety
branch
from
March 22, 2024 18:38
5cfc118 to
22f2570
Compare
JelleZijlstra
approved these changes
Mar 23, 2024
JelleZijlstra
left a comment
JelleZijlstra
left a comment
Collaborator
There was a problem hiding this comment.
I feel ideally we should only reformat real docstrings, but this still preserves the invariant that we only change strings that aren't executed, so this is fine.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4288, regressed by #4270