Repository navigation
fix: reserved field inside group blocks fail parsing - #2058
Merged
mkruskal-google merged 3 commits intoMay 7, 2025
Merged
mkruskal-google merged 3 commits into
mkruskal-google merged 3 commits into
Conversation
mkruskal-google
self-requested a review
May 7, 2025 21:21
Contributor
|
This lgtm, but can you add a test case? Maybe just a bit in tests/data/uncommon.proto to lock down that this continues to work? Edit: nvm, just added your test case from the issue :) |
mkruskal-google
approved these changes
May 7, 2025
Merged
rumpusroobot
pushed a commit
to proctorio/protobuf.js
that referenced
this pull request
Jul 27, 2026
* fix: reserved field inside group blocks fail parsing * Add test case from issue --------- Co-authored-by: Mike Kruskal <62662355+mkruskal-google@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add handler to "reserved" field when parsing tokens for parseGroup.
This fixes issue #2059