Repository navigation
Upgrade Golang version v1.24 - #1738
Conversation
Signed-off-by: dongjiang <dongjiang1989@126.com>
… examples name Signed-off-by: dongjiang <dongjiang1989@126.com>
Signed-off-by: dongjiang <dongjiang1989@126.com>
Signed-off-by: dongjiang <dongjiang1989@126.com>
kakkoyun
left a comment
kakkoyun
left a comment
There was a problem hiding this comment.
Thanks for the PR. I have some comments.
| module github.com/prometheus/client_golang | ||
|
|
||
| go 1.21 | ||
| go 1.22 |
There was a problem hiding this comment.
We don't need to bump this if we don't use any new APIs from 1.22.
We officially support only the last three versions but if we don't use new APIs no need to break compatibly.
There was a problem hiding this comment.
Thanks @kakkoyun
I got it
Revert golang version to 1.21
There was a problem hiding this comment.
Except we do need to change it if we remove 1.21 from the supported version test matrix.
There was a problem hiding this comment.
You’re right—I’m still undecided on this. We could continue testing all versions down to the minimum required API level (1.21) since there’s no downside to doing so.
That said, we could also make the case for upgrading the Go toolchain, given its strong backward compatibility.
Better to stick what we have right now.
There was a problem hiding this comment.
Except we do need to change it if we remove 1.21 from the supported version test matrix.
Thanks @SuperQ
I got it.
| module github.com/prometheus/client_golang | ||
|
|
||
| go 1.21 | ||
| go 1.22 |
There was a problem hiding this comment.
You’re right—I’m still undecided on this. We could continue testing all versions down to the minimum required API level (1.21) since there’s no downside to doing so.
That said, we could also make the case for upgrading the Go toolchain, given its strong backward compatibility.
Better to stick what we have right now.
* update golang version Signed-off-by: dongjiang <dongjiang1989@126.com> * fix the new tests analyzer reports common mistakes in declarations of examples name Signed-off-by: dongjiang <dongjiang1989@126.com> * Update .github/workflows/golangci-lint.yml Signed-off-by: dongjiang <dongjiang1989@126.com> * update golanglint list Signed-off-by: dongjiang <dongjiang1989@126.com> --------- Signed-off-by: dongjiang <dongjiang1989@126.com>
This library supports the three most recent major releases of Go. Move golang v1.21
Fix Examples case name: