Skip to content

dependency patching should happen before engineStrict verification #9603

Description

@KuSh

Verify latest release

  • I verified that the issue exists in the latest pnpm release

pnpm version

No response

Which area(s) of pnpm are affected? (leave empty if unsure)

CLI

Link to the code that reproduces this issue or a replay of the bug

No response

Reproduction steps

Create a project which depends on storybook-addon-mock-date@0.10.0

Patch dependency to change its engines conf with

diff --git a/package.json b/package.json
index 9821c568a571a0f3e4ee3ec9f91db0ad8cbb224e..974be0896c228e2b27773b4da8ddda85bc74c1dc 100644
--- a/package.json
+++ b/package.json
@@ -28,7 +28,7 @@
     "./package.json": "./package.json"
   },
   "engines": {
-    "node": "22.16.0"
+    "node": ">=20.0.0"
   },
   "files": [
     "dist/**/*",

Switch to node 22.11 and try to install with engineStrict: true

Installation fails with

ERR_PNPM_UNSUPPORTED_ENGINE  Unsupported environment (bad pnpm and/or Node.js version)
Your Node version is incompatible with "storybook-addon-mock-date@0.10.0(patch_hash=069140515f1ebc7588616fb8a3d51faf0b2286c671f735afdfaa4367a2789485)".

Describe the Bug

ERR_PNPM_UNSUPPORTED_ENGINE should not happen if dependency engines property is patched

Expected Behavior

Patching engines property should allow avoiding engineStrict check on particular dependency

Which Node.js version are you using?

v22.11.0

Which operating systems have you used?

  • macOS
  • Windows
  • Linux

If your OS is a Linux based, which one it is? (Include the version if relevant)

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions