Skip to content

test: wait for explicit calls in directory test - #1442

Merged
paulmillr merged 2 commits into
mainfrom
flaky-buns
Nov 16, 2025
Merged

paulmillr merged 2 commits into
mainfrom
flaky-buns

Conversation

@43081j

@43081j 43081j commented Nov 11, 2025 •

Copy link
Copy Markdown
Collaborator

This hopefully fixes the flakiness since we explicitly wait for each
step rather than hoping the delay was right.

Fixes #1437 too

This hopefully fixes the flakiness since we explicitly wait for each
step rather than hoping the delay was right.
@43081j
43081j force-pushed the flaky-buns branch 6 times, most recently from 2766a1a to c08a6c4 Compare November 11, 2025 14:57
@43081j

43081j commented Nov 11, 2025

Copy link
Copy Markdown
Collaborator Author

well i can reproduce the bun problem now so will dig into it before i merge this or #1441

it feels like a bun bug but not sure yet

@43081j

43081j commented Nov 12, 2025

Copy link
Copy Markdown
Collaborator Author

its a bug in bun, or many bugs. the usual suspect

im going to merge this and we can fix our bun tests when bun themselves fix their runtime

@43081j
43081j requested a review from paulmillr November 12, 2025 09:41
@paulmillr
paulmillr merged commit de5a34c into main Nov 16, 2025
55 of 78 checks passed
@43081j
43081j deleted the flaky-buns branch November 16, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Events are dropped when watching multiple files from one FSWatcher

2 participants