Repository navigation
chore: Replace deprecated gofumpt extra-rules with extra options - #9062
Merged
pellared merged 2 commits intoOct 1, 2026
Merged
Conversation
kijimad
requested review from
MrAlias,
XSAM,
dashpole,
dmathieu,
flc1125,
pellared and
ps-mir
as code owners
October 1, 2026 11:02
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9062 +/- ##
=======================================
- Coverage 89.1% 89.1% -0.1%
=======================================
Files 338 338
Lines 22274 22274
=======================================
- Hits 19855 19853 -2
- Misses 2419 2421 +2 🚀 New features to boost your workflow:
|
dmathieu
approved these changes
Oct 1, 2026
ps-mir
approved these changes
Oct 1, 2026
pellared
approved these changes
Oct 1, 2026
Member
|
@kijimad, do you want to make the same PR in https://github.com/open-telemetry/opentelemetry-go-contrib ? |
Contributor
Author
|
@pellared |
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8942.
make lintstill warns becauseextra-rules: truewas kept:extra-rules: truecurrently enables all three gofumpt extra rules (gofumpt v0.12.0).Following the warning as-is would turn off
clothe-returnsandbalance-calls, so all three are listed to keep formatting unchanged.Testing
make lintno longer prints the deprecation warning, and all modules report0 issues.