feat: add redirect request option - #636
Conversation
gr2m
left a comment
gr2m
left a comment
There was a problem hiding this comment.
Could you add a test please, to avoid a future regression?
|
It's not a custom option though? I'm not quite sure if we discussed removing the |
|
After discussion in #635 I did think this was the desired current behavior so meant to close this PR. I am happy to add a test case to ensure this option works if it is desired for this feature to be re-introduced. |
|
@wolfy1339 can you recall specifically why we removed the |
|
I don't know. |
gr2m
changed the title
redirect request option
|
It's odd to me that we left I think for now I would leave it as is as we have a working workaround. We can revisit the discussion as more folks experience the lack of |
This seems to have fixed the problem with the broken test
|
Requires octokit/types.ts#630 |
* Fixed regression of redirect option being passed through to fetch introduced in #599, and moves it instead to the `requestOption.request` object * build: upgrade jest to fix test regression with `globalThis` being read-only
|
🎉 This PR is included in version 9.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 participants
Resolves #635
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Is it breaking? not really, this is the desired behavior, I can't imagine anyone has a valid use case to set the redirect option and have it ignored.
Please see our docs on breaking changes to help!